-
-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow @rules and @console_rules to be registered as loose plugins #6652
Comments
@cosmicexplorer : I think you had a ticket about this somewhere? |
Oh, wait. I'm not sure that this is accurate. Any backend with a It's only contrib plugins that don't support declaring |
Specifically, could I write this test: 9b3d18a#diff-c43b8b5f4e0613890bad998aae1f95fdR33 without adding the console_rule to pants proper? |
Correct, #5970 (which adds this) should be unblocked by the other PR I will have in today. Looking at the comment in |
Yes. |
@cosmicexplorer : Ideally the "plugins can declare @rules" portion of #5970 would be split out and landed independently. But given that @illicitonion isn't actually blocked here, if nothing else ends up needing to declare |
Left a comment in #5970 basically laying out the plan for that PR (which now does not involve moving a ton of code across the codebase and resolving this issue at the same time). |
This was fixed! |
Right now, all @rules and @console_rules must be distributed in the pants source; we don't allow them to be registered separately.
When we're slightly more stable in the API, we should fix this.
The text was updated successfully, but these errors were encountered: