-
-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate BUILD-file deletion defenses into --changed-include-dependees
#7581
Comments
It occurs to me that the current implementation of pants/src/python/pants/engine/legacy/graph.py Lines 405 to 453 in a33fc0b
Worth experimenting with / encoding in some tests. |
Ok, false alarm. It looks like all of these cases are covered by |
When using
--changed-include-dependees
, it's important to locate targets affected by deleted/modified BUILD files.In Twitter's CI (equivalent to), there are a few defenses layered on top of
--changed-include-dependees
in order to detect cases that are currently missed there. We should incorporate those defenses into the implementation of--changed-include-dependees
such that the effect of change detection is that we definitely end up parsing and validating targets that might have been transitively affected by a file removal.A sketch of the relevant snippet:
The text was updated successfully, but these errors were encountered: