Make sure namespace packages (e.g. virtualenvwrapper) don't break pex #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itamarst
changed the title
|
I'll fix the (minor style) error tomorrow. |
kwlzn
approved these changes
Jan 6, 2017
| try: | ||
| module.__path__[0] | ||
| except (TypeError, KeyError, IndexError): | ||
| TRACER.log('Dropping %s' % (module_name,), V=3) |
There was a problem hiding this comment.
given the treatment of module.__path__ on the lines below - which includes index access as well as a .pop() method call - I wonder if an explicit type check might be more appropriate as a drop condition vs the attempted index access?
e.g.
if not isinstance(module.__path__, list):
TRACER.log(...)
continue
|
OK, updated. Thanks for the quick review! A speedy release would be nice: for server-side deploys this is less of an issue, but for my use case (distributing developer tools) this is a blocking bug. If anyone else is using pex to distribute developer tools their tool will be breaking at random. |
Closed
|
@itamarst thanks for the PR! this went out in the 1.1.19 release today. |
facebook-github-bot
pushed a commit
to facebook/buck
that referenced
this pull request
Nov 1, 2017
Summary: This diff is basically just an import of pex-tool/pex#338, but without the tests (we don't have the pex tests in this repo?). This solves a problem where the pex would fail to run any time you had a namespaced package in your path. Test Plan: eyes Reviewed By: sdwilsh fbshipit-source-id: 8d500c3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #337.
Let me know what else I can do to get this accepted.