Prepare the 1.2.0 release. #352
Conversation
I guess the wrong PR #.
|
|
||
| PACKAGING_REQUIREMENT = 'packaging>=16.8,<17.0' | ||
| SETUPTOOLS_REQUIREMENT = 'setuptools>=30.0,<35.0' |
There was a problem hiding this comment.
I noticed in the changelog that the 34.0.0 version of setuptools is the first release that forgoes it's previously vendored deps in favor of typical dep linkages - but it seems there's a slight chicken/egg scenario here based on their strong advice to always use pip to install that made me wonder if this will break things for pex? may be good to do some extra tire kicking around setuptools==34.0.0 in particular.
also, I wonder if it'd make sense to relax the lower end of this range a bit - perhaps early in the 2x.0.0 series (e.g. setuptools>=20.0,<35.0) - just to ensure flexibility for other composed libs in the same environment which may not be prepared for 30.x (which was just released in Dec '16).
There was a problem hiding this comment.
... made me wonder if this will break things for pex?
I think you meant pants, and agreed - not sure. Suggestions incorporated.
Exclude >=34 for now since it potentially changes install behavior of pex when used as a lib and relax the lower bound to be modern, but not overly so.
No description provided.