-
-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing a preamble file to the CLI #400
Conversation
tests/test_pex_binary.py
Outdated
tmpfile.write(to_bytes('print "foo!"')) | ||
tmpfile.flush() | ||
|
||
# XXX ? can we assert that the PEXBuilder actually gets the contents of the preamble file? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, how about via execution of a built pex with pre-amble? If the preamble echoed, say and exited with a known exit code you could test bout the stdout and the exit code are as expected.
@jsirois -- Done. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this LGTM - thanks for the PR!
will plan on merging this tomorrow afternoon to allow for any straggler follow-up comments.
This PR adds a new CLI option,
-p
or--preamble-file
, that is used to provide a preamble to the pex builder object.We use pex via its API in the internal build tooling at NerdWallet (👋, we're neighbors!). We've been leveraging it for multi-platform support, but now that #394 / 1.2.9 has landed the only thing missing from the CLI that we leverage is the preamble in the builder, which was pretty easy to hook up. Once this PR has landed we can remove all of the API integration and just rely on the
pex
CLI!The CLI option and the PEXBuilder preamble functionality are covered by tests.
Local functional testing: