Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCIE_BOOT=update scie-pants & PANTS_BOOTSTRAP_VERSION=report scie-pants are clunky. #32

Open
jsirois opened this issue Dec 19, 2022 · 5 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@jsirois
Copy link
Contributor

jsirois commented Dec 19, 2022

The former leaks an implementation detail. A Pants user should not need to be confronted with what scie means. The latter is just plain clunky.

Ideally Pants would support a bootstrap pseudo-goal since the namespace has already been taken by PANTS_BOOTSTRAP_TOOLS in the existing ./pants script. That would allow for scie-pants bootstrap update and scie-pants bootstrap version respectively (or scie-pants bootstrap --update and scie-pants bootstrap --version to align slightly better with how Pants goals work).

@jsirois jsirois added bug Something isn't working enhancement New feature or request labels Dec 19, 2022
@jsirois
Copy link
Contributor Author

jsirois commented Jan 22, 2023

N.B. It seems the scie-pants binary name has converged on pants quickly; so modify the above as such; I.E.: pants bootstrap update or pants bootstrap --update.

@tdyas
Copy link

tdyas commented Jan 22, 2023

Prior art "self" in Rustup: rustup self update

@jsirois
Copy link
Contributor Author

jsirois commented Jan 22, 2023

Yeah. It's unfortunate we already had the (probably inadvertent) land grab on bootstrap via the PANTS_BOOTSTRAP_TOOLS introduction. I guess we can just grab more land though and deprecate the bootstrap stuff or leave the world split.

@kaos
Copy link
Member

kaos commented Jan 23, 2023

Not being well versed in rust, self isn't any more obvious than bootstrap to me. What I mean is, I think we could go with what feels most natural for Pants regardless of the choice rust has made for them. (i.e. I'm fine with either just that the referenced prior art may not span far outside the rust community.. or maybe it does but I'm unaware)

@wfscheper
Copy link

wfscheper commented Mar 10, 2023

poetry also uses self as a command namespace for managing itself: https://python-poetry.org/docs/cli/#self

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants