fix: hide AggregateError message stack

closes #336
panva · Feb 26, 2021 · 3011cca · 3011cca
1 parent 588bee9
commit 3011cca
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/lib/issuer.js b/lib/issuer.js
@@ -267,7 +267,13 @@ class Issuer {
           (discoveryURL) => wellKnownUri.startsWith(discoveryURL),
         ),
       });
-    }));
+    })).catch((err) => {
+      if (err instanceof pAny.AggregateError) {
+        err.message = `Issuer.discover() failed.${err.message.split('\n')
+          .filter((line) => !line.startsWith('        at')).join('\n')}`;
+      }
+      throw err;
+    });
   }
 
   /* istanbul ignore next */

diff --git a/test/issuer/discover_issuer.test.js b/test/issuer/discover_issuer.test.js
@@ -210,6 +210,8 @@ describe('Issuer#discover()', () => {
     return Issuer.discover('https://op.example.com')
       .then(fail, function (error) {
         expect(error.name).to.equal('AggregateError');
+        expect(error.message).to.match(/^Issuer\.discover\(\) failed\.\n/);
+        expect(error.message).not.to.contain('node_modules');
         expect([...error].some((err) => {
           try {
             expect(err.name).to.equal('OPError');
@@ -242,6 +244,8 @@ describe('Issuer#discover()', () => {
     return Issuer.discover('https://op.example.com')
       .then(fail, function (error) {
         expect(error.name).to.equal('AggregateError');
+        expect(error.message).to.match(/^Issuer\.discover\(\) failed\.\n/);
+        expect(error.message).not.to.contain('node_modules');
         expect([...error].some((err) => {
           try {
             expect(err.name).to.equal('OPError');
@@ -263,6 +267,8 @@ describe('Issuer#discover()', () => {
     return Issuer.discover('https://op.example.com')
       .then(fail, function (error) {
         expect(error.name).to.equal('AggregateError');
+        expect(error.message).to.match(/^Issuer\.discover\(\) failed\.\n/);
+        expect(error.message).not.to.contain('node_modules');
         expect([...error].some((err) => {
           try {
             expect(err.name).to.equal('OPError');
@@ -284,6 +290,8 @@ describe('Issuer#discover()', () => {
     return Issuer.discover('https://op.example.com')
       .then(fail, function (error) {
         expect(error.name).to.equal('AggregateError');
+        expect(error.message).to.match(/^Issuer\.discover\(\) failed\.\n/);
+        expect(error.message).not.to.contain('node_modules');
         expect([...error].some((err) => {
           try {
             expect(err.name).to.eql('ParseError');
@@ -305,6 +313,8 @@ describe('Issuer#discover()', () => {
     return Issuer.discover('https://op.example.com')
       .then(fail, function (error) {
         expect(error.name).to.equal('AggregateError');
+        expect(error.message).to.match(/^Issuer\.discover\(\) failed\.\n/);
+        expect(error.message).not.to.contain('node_modules');
         expect([...error].some((err) => {
           try {
             expect(err.name).to.equal('OPError');
@@ -325,6 +335,8 @@ describe('Issuer#discover()', () => {
     return Issuer.discover('https://op.example.com')
       .then(fail, function (error) {
         expect(error.name).to.equal('AggregateError');
+        expect(error.message).to.match(/^Issuer\.discover\(\) failed\.\n/);
+        expect(error.message).not.to.contain('node_modules');
         expect([...error].some((err) => {
           try {
             expect(err.name).to.equal('OPError');