feat: electron v6.x runtime support

Testing using electron to ensure electron is a first-class citizen
runtime.

.travis.yml

@@ -29,3 +29,11 @@ matrix:
         - nvm i node
         - npm i
       script: npm test
+    - name: "Test Suite - Electron - 6.0.0"
+      language: node_js
+      node_js: stable
+      script: xvfb-run npx electron@6.0.0 ./test/electron
+    - name: "Test Suite - Electron - ^6.0.0"
+      language: node_js
+      node_js: stable
+      script: xvfb-run npx electron@6 ./test/electron

README.md

@@ -213,6 +213,11 @@ client.callback('https://client.example.com/callback', params, { nonce }) // =>
   });
 ```
 
+## Electron Support
+
+Electron v6.x runtime is supported to the extent of the crypto engine BoringSSL feature parity with
+standard Node.js OpenSSL.
+
 ## FAQ
 
 #### Semver?

docs/README.md

@@ -400,7 +400,7 @@ the following are valid values for `token_endpoint_auth_method`.
   header as described in [RFC6749](https://tools.ietf.org/html/rfc6749#section-2.3.1)
 - `client_secret_post` - client_id and client_secret is sent in the request body as described in
   [RFC6749](https://tools.ietf.org/html/rfc6749#section-2.3.1)
-- `client_secret_jwt` - using `client_secret` as a shared symmetrical secret a `client_assertion` is
+- `client_secret_jwt` - using `client_secret` as a shared symmetric secret a `client_assertion` is
   sent in the request body
 - `private_key_jwt` - using the asymmetric keys provided via `jwks` a `client_assertion` is sent
   in the request body

lib/client.js

@@ -1279,8 +1279,8 @@ module.exports = (issuer, aadIssValidation = false) => class Client extends Base
         '',
       ].join('.');
     } else {
-      const symmetrical = alg.startsWith('HS');
-      if (symmetrical) {
+      const symmetric = alg.startsWith('HS');
+      if (symmetric) {
         key = await this.joseSecret();
       } else {
         const keystore = instance(this).get('keystore');
@@ -1296,7 +1296,7 @@ module.exports = (issuer, aadIssValidation = false) => class Client extends Base
 
       signed = jose.JWS.sign(payload, key, {
         ...header,
-        kid: symmetrical ? undefined : key.kid,
+        kid: symmetric ? undefined : key.kid,
       });
     }
 

package.json

@@ -10,15 +10,16 @@
     "client",
     "connect",
     "dynamic",
+    "electron",
     "hybrid",
     "identity",
     "implicit",
     "oauth",
     "oauth2",
     "oidc",
     "openid",
-    "relying party",
     "passport",
+    "relying party",
     "strategy"
   ],
   "homepage": "https://github.com/panva/node-openid-client",
@@ -36,7 +37,7 @@
     "test": "mocha"
   },
   "dependencies": {
-    "@panva/jose": "^1.3.0",
+    "@panva/jose": "^1.6.1",
     "base64url": "^3.0.1",
     "got": "^9.6.0",
     "lodash": "^4.17.13",

test/electron.js

@@ -0,0 +1,16 @@
+/* eslint-disable */
+
+const { app } = require('electron');
+
+const { Base } = require('mocha/lib/reporters');
+
+const orig = Base.prototype.epilogue;
+
+Base.prototype.epilogue = function epilogue() {
+  orig.call(this);
+  const { stats: { failures } } = this;
+
+  app.exit(failures ? 1 : 0);
+}
+
+require('../node_modules/.bin/mocha');