Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max_age defined as string rather than number #279

Closed
2 tasks done
ruiengana opened this issue Jul 26, 2020 · 1 comment
Closed
2 tasks done

max_age defined as string rather than number #279

ruiengana opened this issue Jul 26, 2020 · 1 comment
Labels

Comments

@ruiengana
Copy link

ruiengana commented Jul 26, 2020

Describe the bug
In AuthorizationParameters interface max_age is defined as string rather than number.

To Reproduce

<setup client>
const max_age = 86400;
const request = await client.requestObject({
  scope,
  response_type,
  redirect_uri,
  state,
  nonce,
  max_age,
  claims,
  code_challenge,
  code_challenge_method,
});

}

Steps to reproduce the behaviour:

  1. Define max_age as number, e.g. 86400
  2. Initiate a client and produce a RequestObject with max_age claim

Expected behaviour
Expected RequestObject to accept max_age claim as number.

Environment:

  • openid-client version: [v3.15.8]
  • node version: [v12.16.2]

Additional context

  • the bug is happening on latest openid-client too.
  • i have searched the issues tracker on github for similar issues and couldn't find anything related.
@panva panva closed this as completed in 5ce2a73 Jul 26, 2020
@panva panva added bug and removed triage labels Jul 26, 2020
@ruiengana
Copy link
Author

Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants