-
-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v5.x doesn't work with some providers #420
Labels
Comments
HitkoDev
added a commit
to HitkoDev/node-openid-client
that referenced
this issue
Oct 28, 2021
This resolves panva#420 420
@HitkoDev thank you for bringing it up, i'll try and fix it promptly. |
panva
changed the title
v4.x.x doesn't work with some providers
v5.x doesn't work with some providers
Oct 28, 2021
HitkoDev
added a commit
to HitkoDev/node-openid-client
that referenced
this issue
Oct 28, 2021
panva
pushed a commit
that referenced
this issue
Oct 28, 2021
Closes #420 Co-authored-by: Filip Skokan <panva.ip@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the bug
Some OAuth providers (notably
login.microsoftonline.com
) don't accept requests withTransfer-encoding: chunked
, which is the default behaviour in NodeJS unlesscontent-length
header is provided.To Reproduce
Steps to reproduce the behaviour:
Expected behaviour
Returns request response.
Actual behaviour
Throws
OPError: expected 200 OK, got: 404 Not Found
.Environment:
Additional context
This was introduced by removing
got
dependency which took care of settingcontent-length
header.The text was updated successfully, but these errors were encountered: