Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path name with colon causes problems with gsettings and GSETTINGS_SCHEMA_DIR #322

Closed
wbolster opened this issue Jul 1, 2020 · 7 comments · Fixed by #556
Closed

path name with colon causes problems with gsettings and GSETTINGS_SCHEMA_DIR #322

wbolster opened this issue Jul 1, 2020 · 7 comments · Fixed by #556
Assignees
Labels
enhancement Adds a new feature or extends scope

Comments

@wbolster
Copy link

wbolster commented Jul 1, 2020

this extension uses a : (colon) character in its directory name in ~/.local/gnome-shell/extensions, namely paperwm@hedning:matrix.org, which causes problems when using GSETTINGS_SCHEMA_DIR=... and the gsettings command line tool. the : is interpreted as a path separator.

this means gsettings cannot be used to configure this extension, as suggested in the readme.

since this is only the extension (out of quite a few on my system) using a non-standard character, i suggest to adhere to the established practices and conventions for gnome extensions, and use an identifier and directory name that do not cause problems.

@hedning
Copy link
Member

hedning commented Jul 1, 2020

Right, that's a good point, the directory won't work in at least XDG_DATA_DIR which is colon separated. Now I'm fairly certain GSETTINGS_SCHEMA_DIR isn't colon separated, it's only meant to be used by a single directory, as the suggested dconf-editor hack in the readme works.

As an aside you can set things without a schema too (at least with dconf).

Will have a think about changing the id, and how a smooth upgrade can be handled.

@wbolster
Copy link
Author

wbolster commented Jul 1, 2020

glib changed, and it only works with older versions

@hedning
Copy link
Member

hedning commented Jul 1, 2020

Right, never noticed as I've only really used dconf-editor together with GSETTINGS_SCHEMA_DIR, and looking at the code it does some manual handling were it treats it as a single directory. So that's actually a bug in dconf-editor :p

@wbolster
Copy link
Author

wbolster commented Apr 8, 2021

this popped up again in #376 (comment)

the best would be to just ‘get with the program’ 😉 and use the same naming conventions as pretty much all other gnome extensions. without a colon, that is.

@hedning
Copy link
Member

hedning commented Apr 8, 2021

Yeah will just have to bite bullet here, propably do it for the 40 release

@jtaala jtaala self-assigned this Mar 11, 2023
@jtaala
Copy link
Collaborator

jtaala commented Mar 11, 2023

To avoid future (potential) issues with this - yeah, I think we should change the id/name to paperwm@hedning.matrix.org?

Will create a PR for this.

@jtaala
Copy link
Collaborator

jtaala commented Aug 2, 2023

Closing as uuid has been changed to safer paperwm@paperwm.github.com.

@jtaala jtaala closed this as completed Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adds a new feature or extends scope
Projects
None yet
3 participants