Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot save changes to DCLP meta before finalization #320

Closed
samosafuz opened this issue May 2, 2022 · 3 comments
Closed

Cannot save changes to DCLP meta before finalization #320

samosafuz opened this issue May 2, 2022 · 3 comments
Assignees

Comments

@samosafuz
Copy link
Member

This morning I approved https://papyri.info/editor/publications/114005 on the DCLP board and set about revising it for finalization. I was able to modify the text and save my changes without any errors, but I cannot do the same with the DCLP meta: https://papyri.info/editor/publications/114005/dclp_meta_identifiers/261381/edit. Whenever I modify any of the fields and attempt to save, it flashes the "We're sorry" card.

@jcowey
Copy link
Member

jcowey commented May 2, 2022

Wonder whether this is in some way similar to #313, where it was "related to changes in REXML, the Ruby built-in XML parsing library, between Ruby version upgrades"

I now note that Biblio is also not functioning properly. When I added an ISBN number I got the 404 error message. #321

@ryanfb
Copy link
Member

ryanfb commented May 2, 2022

I believe this should be fixed by: sosol@3f36201

This is now in production so please let me know if you're still running into issues.

@ryanfb ryanfb closed this as completed May 2, 2022
@samosafuz
Copy link
Member Author

I tested this out last night and again this morning, and things mostly appear ok. But it looks as though there's another bug with author/work stable identifiers: they have been wiped from the records I'm revising. They do not save when entered into the metadata mask, and although I can add them manually to the xml, if I make any further changes to the metadata and save, they get erased again.

Screen Shot 2022-05-03 at 8 45 44 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants