Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support DataType::List cast to json and jsonb #187

Merged
merged 4 commits into from
Jan 3, 2025

Conversation

kysshsy
Copy link
Contributor

@kysshsy kysshsy commented Dec 25, 2024

Ticket(s) Closed

What

Why

How

Support Datatype::List cast to json and jsonb.

Tests

@kysshsy kysshsy changed the title feat: support Datatype::List cast to json and jsonb feat: support DataType::List cast to json and jsonb Dec 25, 2024
@kysshsy kysshsy marked this pull request as ready for review December 30, 2024 15:37
@kysshsy
Copy link
Contributor Author

kysshsy commented Dec 30, 2024

support List type to json and jsonb.
image

Some specific data may cause errors(ERROR: unsupported Unicode escape sequence) that I want to dive into it and fix in future PRs.

@philippemnoel
Copy link
Collaborator

support List type to json and jsonb. image

Some specific data may cause errors(ERROR: unsupported Unicode escape sequence) that I want to dive into it and fix in future PRs.

Would you be willing to open a new issue for this? Since this will close the previous issue. I'll merge this after. Thank you 🙏

@kysshsy
Copy link
Contributor Author

kysshsy commented Jan 2, 2025

Yes. Opened a new issue #188 .

support List type to json and jsonb. image
Some specific data may cause errors(ERROR: unsupported Unicode escape sequence) that I want to dive into it and fix in future PRs.

Would you be willing to open a new issue for this? Since this will close the previous issue. I'll merge this after. Thank you 🙏

Yes. Opened a new issue #188 to track this problem

@philippemnoel
Copy link
Collaborator

Yes. Opened a new issue #188 .

support List type to json and jsonb. image
Some specific data may cause errors(ERROR: unsupported Unicode escape sequence) that I want to dive into it and fix in future PRs.

Would you be willing to open a new issue for this? Since this will close the previous issue. I'll merge this after. Thank you 🙏

Yes. Opened a new issue #188 to track this problem

Thank you!

@philippemnoel philippemnoel merged commit a14415b into paradedb:dev Jan 3, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parquet structured column maps to JSONBOID by default which causes error on scan
2 participants