Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive Nesting in Harvested Drops for DGA Fresh Meat #371

Open
scriptsforweirdos opened this issue Sep 7, 2023 · 0 comments
Open

Excessive Nesting in Harvested Drops for DGA Fresh Meat #371

scriptsforweirdos opened this issue Sep 7, 2023 · 0 comments

Comments

@scriptsforweirdos
Copy link

Looking at [PPJA] Fresh Meat/[DGA] Fresh Meat/crops.json.

I'm seeing what appears to be excessive nesting in the HarvestedDrops Params.

Example:

"HarvestedDrops": [
     {
	"MaximumHarvestedQuantity": 2,
	"ExtraQuantityChance": 0.1,
	"Item": [
			{
				"Weight": 1.0,
				"Value": {
					"Value": "ppja.freshmeat.DGA/Alpaca Meat"
				}
			},
			{
				"MinimumHarvestedQuantity": 1,
				"MaximumHarvestedQuantity": 1,
				"ExtraChance": 0.1,
				"Item": [
					{
						"Weight": 1,
						"Value": null
					},
					{
						"Weight": 1,
						"Value": {
							"Value": "ppja.freshmeat.DGA/Alpaca Fell",
						}
					},
				]
			}
		]
	}
 ],

Should probably instead be:

"HarvestedDrops": [
	{
		"MaximumHarvestedQuantity": 2,
		"ExtraQuantityChance": 0.1,
		"Item": [
					{
						"Weight": 1.0,
						"Value": {
							"Value": "ppja.freshmeat.DGA/Alpaca Meat"
						}
					},
				]
	},
	{
		"MinimumHarvestedQuantity": 1,
		"MaximumHarvestedQuantity": 1,
		"ExtraChance": 0.1,
		"Item": [
			{
				"Weight": 1,
				"Value": null
			},
			{
				"Weight": 1,
				"Value": {
					"Value": "ppja.freshmeat.DGA/Alpaca Fell",
				}
			},
		]
	}
],

Also I suspect "ExtraChance" in the doubly-nested node should be "ExtraQuantityChance" but the converter didn't run deep enough to catch the string conversion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant