Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request: Purge git crates and publish to crates.io #63

Open
2 tasks
Autoparallel opened this issue Dec 13, 2023 · 3 comments
Open
2 tasks

request: Purge git crates and publish to crates.io #63

Autoparallel opened this issue Dec 13, 2023 · 3 comments

Comments

@Autoparallel
Copy link

Idea

It would be great to get the artemis crates hosted on crates.io to make downstream package management more easy and to make downstream packages also able to host on crates.io.

@FrankieIsLost what do you think?

Starting Point

Perhaps we just start with artemis-core as the namespace is available on crates.io. At the workspace level, all the deps are free of git hosted crates. This means we need to swap out:

  • opensea-stream (this one is your crate, Frankie and I haven't gone into depth here to see if this can be done easily).
  • ethers-flashbots this can be swapped immediately.

Feedback

I am happy to help you get this done. Just let me know if I can be of help. As a side benefit, we could consider using release-plz for version control and deployment.

@the-emerald
Copy link

Hi, I'm the maintainer of opensea-stream which is on crates.io.

I believe the only change made in the fork is that ethers is bumped to 2 now. I've been preparing a release which matches this and adds a few more message types that OpenSea has since added.

Should be ready in a few days!

@0xJepsen
Copy link

0xJepsen commented Dec 21, 2023

Circling back on this as it now seems possible and is somewhat related to #64. @FrankieIsLost are you actively maintaining or is this delegated?

@the-emerald
Copy link

the-emerald commented Dec 21, 2023

One last thing before I cut a release: I believe OpenSea has made themselves available on lots of chains nowadays. Does anyone know a full list of what is supported in their Stream API?

https://github.com/wanderers-nft/opensea-stream-rs/blob/master/src/schema.rs#L180

A link or PR would be super welcome! Would like to include more chains if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants