Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undetectable vegeta installation results in cryptic error #61

Open
mattsse opened this issue Jul 4, 2024 · 0 comments
Open

Undetectable vegeta installation results in cryptic error #61

mattsse opened this issue Jul 4, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jul 4, 2024

local version detection is broken if vegeta is missing

python3 -m flood version --json

will return 1 if which vegeta fails:

result = subprocess.check_output(['which', 'vegeta'])

this raises an exception if vegeta is not installed.

resulting in a cryptic error

packages/flood/tests/load_tests/load_test_runs.py", line 308, in _run_load_test_remotely
    remote_flood_version = remote_installation['flood_version']
                           ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
TypeError: 'int' object is not subscriptable

perhaps this command can be wrapped in a try statement and raise an error for missing vegeta?

@mattsse mattsse added the bug Something isn't working label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant