Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: github plugin that shows bundle size diff on every PR #58

Open
transmissions11 opened this issue Apr 3, 2023 · 5 comments
Open

Comments

@transmissions11
Copy link
Member

self explanatory from title — would be nice to have exact numbers/percentages on how much each PR and the deps they add contribute to bundle size to avoid bloating the app

@transmissions11
Copy link
Member Author

one option: https://github.com/sarthak-saxena/JSBundleSize (doesn't show diff tho)

@dalechyn
Copy link
Contributor

dalechyn commented Apr 3, 2023

@transmissions11
Copy link
Member Author

oo nice this looks great, @h0tw4t3r wanna PR it in?

@dalechyn
Copy link
Contributor

dalechyn commented Apr 3, 2023

oo nice this looks great, @h0tw4t3r wanna PR it in?

yeah, lemme take that.

eta 24h

@dalechyn
Copy link
Contributor

dalechyn commented Apr 5, 2023

@transmissions11, I've spent some time with implementing this, bundle-size-diff is not our choice since it's for webpack, and here we use rollup.

I've generated the bundle stats files with rollup-plugin-visualizer, but the format is different and bundle-size-diff can't eat it.

Which brings us back to the search of an action that builds a diff based on rollup-plugin-visualizer plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants