Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce EngineApiKind #10124

Closed
Tracked by #8742
mattsse opened this issue Aug 6, 2024 · 1 comment
Closed
Tracked by #8742

Introduce EngineApiKind #10124

mattsse opened this issue Aug 6, 2024 · 1 comment
Labels
C-enhancement New feature or request S-stale This issue/PR is stale and will close with no further activity

Comments

@mattsse
Copy link
Collaborator

mattsse commented Aug 6, 2024

There are certain OPstack differences in the engine API

such as

// On Optimism, the proposers are allowed to reorg their own chain at will.
#[cfg(feature = "optimism")]
if self.blockchain.chain_spec().is_optimism() {

// OPTIMISTIC SYNCING
//
// It can happen when the node is doing an
// optimistic sync, where the CL has no knowledge of the finalized hash,
// but is expecting the EL to sync as high
// as possible before finalizing.
//
// This usually doesn't happen on ETH mainnet since CLs use the more
// secure checkpoint syncing.
//
// However, optimism chains will do this. The risk of a reorg is however
// low.
debug!(target: "consensus::engine", hash=?state.head_block_hash, "Setting head hash as an optimistic pipeline target.");
return Some(state.head_block_hash)

but overall the engine API impl is more or less the same so we can introduce these conditional checks by introducing an enum like

enum EngineApiKind {
  Ethereum,
  OpStack
}
Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Aug 28, 2024
@mattsse mattsse closed this as completed Aug 28, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request S-stale This issue/PR is stale and will close with no further activity
Projects
Archived in project
Development

No branches or pull requests

1 participant