Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert pending block to a watch channel #10157

Closed
Tracked by #8742
mattsse opened this issue Aug 7, 2024 · 4 comments · Fixed by #10203
Closed
Tracked by #8742

Convert pending block to a watch channel #10157

mattsse opened this issue Aug 7, 2024 · 4 comments · Fixed by #10203
Assignees
Labels
C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Aug 7, 2024

it is beneficial to have a listener for the pending block:

/// The pending block that has not yet been made canonical.
pending: RwLock<Option<BlockState>>,

like we do with the latest as well:

/// The block that the beacon node considers safe.
safe_block: watch::Sender<Option<SealedHeader>>,
/// The block that the beacon node considers finalized.
finalized_block: watch::Sender<Option<SealedHeader>>,

TODO

  • convert RwLock into a watch channel

This will be useful for #5617

@mvares
Copy link
Contributor

mvares commented Aug 7, 2024

👊🏻

@mattsse
Copy link
Collaborator Author

mattsse commented Aug 7, 2024

hey @mvares this one's already taken by @jenpaff

perhaps I can interest you in #7490

@jenpaff
Copy link
Collaborator

jenpaff commented Aug 8, 2024

Not related to this issue, but since it's my one, wanted to raise some questions for my own understanding:

  • Small nit pick, but I noticed you don't have a rust-toolchain.toml and was wondering is there a reason? @mattsse
  • 2 tests in lockfile.rs are still failing locally for me on main, will debug, I suppose that's on my end

@mattsse
Copy link
Collaborator Author

mattsse commented Aug 8, 2024

but I noticed you don't have a rust-toolchain.toml and was wondering is there a reason

can't remember why, likely because we never needed it

2 tests in lockfile.rs are still failing locally for me on main, will debug, I suppose that's on my end

It could be because there are some issues if they are run in the same process via cargo t in CI this isn't an issue with cargo nextest

@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants