validate EOF bytecode on Genesis.

[rakita]

Describe the feature

If there ar EOF bytecodes in the Genesis file we should validate those bytes so that only valid EOF bytecodes are found in the state.

The function is found in use revm::interpreter::analysis::validate_raw_eof_inner and it needs to be CodeType::ReturnOrStop type (Will renaming it to ContainerKind::Runtime)

Additional context

It does not affect mainnet, it is a guard for new chains that have EOF enabled from the start.

[danielcdz]

Hello @rakita Can I help with this one?

[rakita]

Hello @rakita Can I help with this one?

Go for it

[danielcdz]

Hello @rakita can you give me more context about this? Is a validation that needs to be moved from to a different function?

[nkysg]

Comment for interests

[emnul]

Hey @danielcdz any updates on your progress here? Happy to take over if you haven't been able to get around to it

[danielcdz]

Hello! @emnul I definitely need some help here, can you provide me more context about the issue?

[emnul]

I think this will help https://github.com/ipsilon/eof/blob/main/spec/eof.md. Although, I'm not sure what "Genesis" refers to in description here. I would reach out to the telegram or open a discussion for more information / clarification.

This is the function that's referred to in the description https://github.com/bluealloy/revm/blob/1ad860469755e3cf71383f45d71c3faaf61d3029/crates/interpreter/src/interpreter/analysis.rs#L75

[danielcdz]

@emnul thank you! do yo have the link to the telegram?

[emnul]

@emnul thank you! do yo have the link to the telegram?

Check the README.md file

[emnul]

The genesis file in the description refers to the genesis.json file which is a JSON-formatted file used to define the initial state of the blockchain at the time of its creation. Here's a good usage example. The struct definition of a Genesis block.

It's possible to define smart contracts in the genesis block (src). If there are EVM Object Format bytecodes in the Genesis file they should be validated so that only valid EOF bytecodes are found in the state.

[emnul]

Hey @rakita is this not already validated on this line? Bytecode::new_raw has EOF validation built-in. Or was the intention here to perform validation in the ChainSpecBuilder or somewhere else? Please clarify

[rakita]

Hey @rakita is this not already validated on this line? Bytecode::new_raw has EOF validation built-in. Or was the intention here to perform validation in the ChainSpecBuilder or somewhere else? Please clarify

Hey, was on vacation last week. This looks like a good place but the function that needs to be called is Bytecode::new_raw_checked and the error needs to be propagated as invalid json.

[emnul]

This looks like a good place but the function that needs to be called is Bytecode::new_raw_checked and the error needs to be propagated as invalid json.

Gotcha, so to be clear, @danielcdz should modify the insert_state function in reth/crates/storage/db-common/src/init.rs to use Bytecode::new_raw_checked and with added error handling such that the error is propagated as invalid json?

[emnul]

@danielcdz feel free to reach out if you run into any other blockers.

[danielcdz]

Hey @emnul and @rakita I really appreciate your help and clarifications here, I'll be working on this and if a get stuck I'll let you guys know!

[nkysg]

Thanks all,I also understand.

[danielcdz]

Hey @emnul I opened a PR for this, I don't know if it is good at all, but I would appreciate it if you take a look and provide feedback.