Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove usage of PeerCount type #10270

Closed
mattsse opened this issue Aug 12, 2024 · 3 comments · Fixed by #10271
Closed

remove usage of PeerCount type #10270

mattsse opened this issue Aug 12, 2024 · 3 comments · Fixed by #10271
Labels
C-debt Refactor of code section that is hard to understand or maintain C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Aug 12, 2024 •
edited
Loading

Describe the feature

we only use PeerCount type here:

reth/crates/rpc/rpc/src/net.rs

Line 40 in af85c13

fn peer_count(&self) -> Result<PeerCount> {

we can get rid of this type and instead replace the response type to U64

ref alloy-rs/alloy#1140 (review)

Additional context

FYI @tcoratger

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Aug 12, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started C-debt Refactor of code section that is hard to understand or maintain and removed S-needs-triage This issue needs to be labelled labels Aug 12, 2024
@mvares
Copy link
Contributor

mvares commented Aug 12, 2024

👌🏻

@tcoratger tcoratger mentioned this issue Aug 12, 2024
Merged
@mattsse
Copy link
Collaborator Author

mattsse commented Aug 12, 2024

@mvares @tcoratger already claimed this via alloy :)

@mvares
Copy link
Contributor

mvares commented Aug 12, 2024

@mvares @tcoratger already claimed this via alloy :)

yeah, I saw here 🔥

@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rpc: rm PeerCount usage tcoratger/reth
2 participants
@mattsse @mvares