Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ExEx provider to subscribe to safe & finalized block updates #10316

Closed
unitezen opened this issue Aug 15, 2024 · 0 comments · Fixed by #10317, #10318 or #10319
Closed

Allow ExEx provider to subscribe to safe & finalized block updates #10316

unitezen opened this issue Aug 15, 2024 · 0 comments · Fixed by #10317, #10318 or #10319
Labels
A-blockchain-tree Related to sidechains, reorgs and pending blocks A-exex Execution Extensions C-enhancement New feature or request

Comments

@unitezen
Copy link
Contributor

unitezen commented Aug 15, 2024 •
edited
Loading

Describe the feature

The FullProvider you get from ExExContext's components doesn't implement ForkChoiceSubscriptions.

We need to modify a few things, which I have made a separate PR for each feature:

  1. feat: add subscribe_safe_block & subscribe_finalized_block to CanonicalInMemoryState #10317
  2. feat(provider): implement ForkChoiceSubscriptions for BlockchainProvider2 #10318
  3. feat: add ForkChoiceSubscriptions to FullProvider supertrait #10319

I'm not sure how to properly pull request separate features like these, where 1 must be merged before 2 and 2 before 3. I've branched them out each with 1, 1&2, 1&2&3. Please kindly suggest any fix if necessary.

Additional context

No response
@unitezen unitezen added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Aug 15, 2024
This was referenced Aug 15, 2024
Merged
Merged
Merged
@shekhirin shekhirin added A-exex Execution Extensions A-blockchain-tree Related to sidechains, reorgs and pending blocks and removed S-needs-triage This issue needs to be labelled labels Aug 15, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-blockchain-tree Related to sidechains, reorgs and pending blocks A-exex Execution Extensions C-enhancement New feature or request
Projects
Reth Tracker
Archived in project
Milestone
No milestone
2 participants
@shekhirin @unitezen