Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend PayloadBuilder Attributes with pool settings #10437

Closed
Tracked by #10435
mattsse opened this issue Aug 22, 2024 · 3 comments · Fixed by #10542
Closed
Tracked by #10435

Extend PayloadBuilder Attributes with pool settings #10437

mattsse opened this issue Aug 22, 2024 · 3 comments · Fixed by #10542
Labels
A-block-building Related to block building S-stale This issue/PR is stale and will close with no further activity

Comments

@mattsse
Copy link
Collaborator

mattsse commented Aug 22, 2024

This type is the input type for the payload builder service

pub struct EthPayloadBuilderAttributes {

currently, this uses all kinds of transactions from the pool

let mut best_txs = pool.best_transactions_with_attributes(BestTransactionsAttributes::new(
base_fee,
initialized_block_env.get_blob_gasprice().map(|gasprice| gasprice as u64),
));

it would be nice to provide the builder with additional settings that restricts what transactions can be included, for example if we want to reuse this for rpc then we want to exclude private transactions.

@mattsse mattsse changed the title Extend PayloadBuilderAttributes with pool settings Extend PayloadBuilder Attributes with pool settings Aug 22, 2024
@mattsse mattsse added the A-block-building Related to block building label Aug 22, 2024
@greged93
Copy link
Contributor

hey @mattsse, I'm down to try this

Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Sep 13, 2024
Copy link
Contributor

This issue was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 20, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-block-building Related to block building S-stale This issue/PR is stale and will close with no further activity
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants