Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor range functions on BlockchainProvider2 #10461

Closed
joshieDo opened this issue Aug 22, 2024 · 0 comments · Fixed by #10460
Closed

Refactor range functions on BlockchainProvider2 #10461

joshieDo opened this issue Aug 22, 2024 · 0 comments · Fixed by #10460
Assignees
@joshieDo
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@joshieDo
Copy link
Collaborator

Describe the feature

Related: #10460

There's a lot of code dup on range queries that fetch from database and inmemory state. They could be be refactored to something like

range(|_| collect_from_db, |_| collect_from_inmemory`

Additional context

No response
@joshieDo joshieDo added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started labels Aug 22, 2024
@joshieDo joshieDo self-assigned this Aug 22, 2024
@joshieDo joshieDo mentioned this issue Aug 22, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshieDo joshieDo

Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(provider): check list size before calling range.nth paradigmxyz/reth
1 participant
@joshieDo