Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify gettransactionbySenderAndNonce #10544

Closed
mattsse opened this issue Aug 26, 2024 · 0 comments · Fixed by #10600
Closed

Unify gettransactionbySenderAndNonce #10544

mattsse opened this issue Aug 26, 2024 · 0 comments · Fixed by #10600
Labels
C-enhancement New feature or request D-complex Quite challenging from either a design or technical perspective Ask for help!

Comments

@mattsse
Copy link
Collaborator

mattsse commented Aug 26, 2024

Describe the feature

ref #10540 (comment)

we currently have two endpoints that do more or less the same ots_ and eth_ getTransactionbySenderAndNonce

this code could be unified of Otterscan impl would depend on a subset of EthServerImpl:

Eth: EthApiServer<RpcTransaction<Eth::NetworkTypes>, RpcBlock<Eth::NetworkTypes>>
and not the rpc server impl.

TODO

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Aug 26, 2024
@mattsse mattsse added D-complex Quite challenging from either a design or technical perspective Ask for help! and removed S-needs-triage This issue needs to be labelled labels Aug 26, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Aug 31, 2024
@github-staff github-staff deleted a comment from masooddahmedd Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request D-complex Quite challenging from either a design or technical perspective Ask for help!
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant