Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use alloy Signature type #10750

Closed
Tracked by #10515 ...
klkvr opened this issue Sep 6, 2024 · 1 comment · Fixed by #10758
Closed
Tracked by #10515 ...

use alloy Signature type #10750

klkvr opened this issue Sep 6, 2024 · 1 comment · Fixed by #10758
Labels
C-debt Refactor of code section that is hard to understand or maintain

Comments

@klkvr
Copy link
Collaborator

klkvr commented Sep 6, 2024

Describe the feature

with alloy-rs/core#719 we can now use Signature to store arbitrary signatures.

first step might be to replace SignatureWithParity:

pub(crate) struct SignatureWithParity {

and after that Signature:

we'll need to make sure to correctly implement decoding. right now for legacy transactions we expect v to be 27 or 28, however alloy's signature will succesfully decode any of 0, 1, 27 or 28 which is incorrect rlp

Additional context

No response

@klkvr klkvr added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Sep 6, 2024
@klkvr klkvr removed the S-needs-triage This issue needs to be labelled label Sep 6, 2024
@leruaa
Copy link
Contributor

leruaa commented Sep 6, 2024

I can take this on.

@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain and removed C-enhancement New feature or request labels Sep 17, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants