Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Tasks generic with Box<dyn TaskExecutor> #11037

Open
mattsse opened this issue Sep 19, 2024 · 4 comments
Open

Replace Tasks generic with Box<dyn TaskExecutor> #11037

mattsse opened this issue Sep 19, 2024 · 4 comments
Assignees
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Sep 19, 2024

Describe the feature

currently we have a few places where we use Tasks as generic,
we can get rid of this by using Box<dyn>

including:

pub const fn with_launch_context(self, task_executor: TaskExecutor) -> WithLaunchContext<Self> {

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled D-good-first-issue Nice and easy! A great choice to get started and removed S-needs-triage This issue needs to be labelled labels Sep 19, 2024
@estensen
Copy link
Contributor

Taking a small break from #10749, pls assign me this one

@mattsse
Copy link
Collaborator Author

mattsse commented Sep 19, 2024

lets focus on the nodebuilder first, this could potentially flag a few limitations in the launch impls

@mattsse
Copy link
Collaborator Author

mattsse commented Sep 19, 2024

for example, I think this isn't part of the trait

pub fn spawn_critical_with_graceful_shutdown_signal<F>(

actually, perhaps we hold off on NodeBuilder first and try tackling the generics in the rpc stack

@estensen
Copy link
Contributor

Sorry, won't have the bandwidth this week. Feel free to assign to someone else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Status: Todo
Development

No branches or pull requests

2 participants