Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking eth_simulate issues #11151

Closed
mattsse opened this issue Sep 24, 2024 · 1 comment
Closed

Tracking eth_simulate issues #11151

mattsse opened this issue Sep 24, 2024 · 1 comment
Assignees
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Sep 24, 2024

Describe the feature

ref #8281

the new eth_simulate impl still has a few inconsistencies, eg

  1. if calls object is missing reth complains, while its not mandatory, here's example test:
    {
    "jsonrpc": "2.0",
    "id": 1,
    "method": "eth_simulateV1",
    "params": [{"blockStateCalls": [{}]}, "latest"]
    }
  2. blockStateCalls is also not mandatory:
    {"jsonrpc":"2.0","id":1,"method":"eth_simulateV1","params":[{},"latest"]}
  3. calls should return a value returnData reth returns returnValue that is not in the spec
  4. logs are returning blockTimestamp which is not in the spec

rpctestgen: lightclient/rpctestgen#33

https://app.circleci.com/pipelines/github/KillariCircleFi/hive/53/workflows/4265e691-49f2-41c6-bcdf-5273393d066b/jobs/641/steps

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Sep 24, 2024
@mattsse mattsse added C-bug An unexpected or incorrect behavior A-rpc Related to the RPC implementation and removed S-needs-triage This issue needs to be labelled labels Sep 24, 2024
@mattsse
Copy link
Collaborator Author

mattsse commented Feb 4, 2025

closing for now, will track issues once they arise

@mattsse mattsse closed this as completed Feb 4, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior C-enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants