Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper function to replace one rpc function #11492

Closed
mattsse opened this issue Oct 4, 2024 · 1 comment · Fixed by #11501
Closed

Add helper function to replace one rpc function #11492

mattsse opened this issue Oct 4, 2024 · 1 comment · Fixed by #11501
Assignees
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Oct 4, 2024

Describe the feature

we already have:

pub fn remove_method_from_configured(&mut self, method_name: &'static str) -> bool {

and

pub fn merge_configured(
&mut self,
other: impl Into<Methods>,
) -> Result<(), RegisterMethodError> {

a nice use case is to replace one specific function, so we'd like to have something like

fn replace_configured(&mut self, impl Into<Methods>)

the method name to remove we get from Methods::method_names

we also want this for individual transports ws,HTTP,ipc

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Oct 4, 2024
@varun-doshi
Copy link
Contributor

I can take this one

@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started A-rpc Related to the RPC implementation and removed S-needs-triage This issue needs to be labelled labels Oct 4, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants