Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug_traceCallMany returns unexpected result #11541

Closed
1 task done
geomad opened this issue Oct 7, 2024 · 4 comments · Fixed by #11586
Closed
1 task done

debug_traceCallMany returns unexpected result #11541

geomad opened this issue Oct 7, 2024 · 4 comments · Fixed by #11586
Labels
A-dependencies Pull requests or issues that are about dependencies A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior

Comments

@geomad
Copy link

geomad commented Oct 7, 2024

Describe the bug

In the past debug_traceCallMany with tracer: 'prestateTracer' and tracerConfig: { diffMode: true } would return the addresses inside post and pre in lowercase.
Since the latest release those addresses are checksumed.

Steps to reproduce

debug_traceCallMany

Node logs

No response

Platform(s)

Linux (x86)

What version/commit are you on?

Commit SHA: ab06997

What database version are you on?

2

Which chain / network are you on?

mainnet

What type of node are you running?

Archive (default)

What prune config do you use, if any?

No response

If you've built Reth from source, provide the full command you used

No response

Code of Conduct

  • I agree to follow the Code of Conduct
@geomad geomad added C-bug An unexpected or incorrect behavior S-needs-triage This issue needs to be labelled labels Oct 7, 2024
@geomad geomad changed the title 1debug_traceCallMany` returns unexpected result debug_traceCallMany returns unexpected result Oct 7, 2024
@mattsse
Copy link
Collaborator

mattsse commented Oct 7, 2024

yeah Address now serializes as checksumed address, which is still valid hex, so this is likely a no-fix

@geomad
Copy link
Author

geomad commented Oct 7, 2024

yeah Address now serializes as checksumed address, which is still valid hex, so this is likely a no-fix

Aren't we aiming though to standarize / be as close as possible on the api as the other clients? I believe erigon returns lowercase (as reth did), unless they changed it as well, since I have not used them for a long time.

Geths debug_traceCall with { tracer: 'prestateTracer', tracerConfig: { diffMode: true } } args also returns everything in lowercase.

In my case, my scripts were broken with that change.

@dallonby
Copy link

dallonby commented Oct 7, 2024

This was a breaking change for me too. Erigon and geth both return the keys lowercased.

@mattsse
Copy link
Collaborator

mattsse commented Oct 8, 2024

ref alloy-rs/core#765

@emhane emhane added A-rpc Related to the RPC implementation A-dependencies Pull requests or issues that are about dependencies and removed S-needs-triage This issue needs to be labelled labels Oct 8, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Pull requests or issues that are about dependencies A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants