Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make setup_op_mainnet_without_ovm general purpose #12090

Closed
mattsse opened this issue Oct 26, 2024 · 4 comments · Fixed by #12134
Closed

Make setup_op_mainnet_without_ovm general purpose #12090

mattsse opened this issue Oct 26, 2024 · 4 comments · Fixed by #12134
Assignees
Labels
A-op-reth Related to Optimism and op-reth C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Oct 26, 2024

Describe the feature

This fills in dummy blocks:

/// Creates a dummy chain (with no transactions) up to the last OVM block and appends the
/// first valid Bedrock block.
pub(crate) fn setup_op_mainnet_without_ovm<Provider>(
provider_rw: &Provider,
static_file_provider: &StaticFileProvider,
) -> Result<(), eyre::Error>
where
Provider: StageCheckpointWriter + BlockWriter,
{

which can be useful for other chains as well #12057

currently this has hardcoded bedrock constants

TODO

  • refactor setup_op_mainnet_without_ovm so that it's general purpose

basically all of these constants should be an argument instead, or we transform all of this into a helper type instead

cc @debjit-bw

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Oct 26, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started A-op-reth Related to Optimism and op-reth and removed S-needs-triage This issue needs to be labelled labels Oct 26, 2024
@hoank101
Copy link
Contributor

hey sir, can i do it?

@mattsse
Copy link
Collaborator Author

mattsse commented Oct 26, 2024

assigned

@debjit-bw
Copy link
Contributor

debjit-bw commented Oct 28, 2024

Hey guys, unfortunately I need this particular feature urgently. @hoank101 if it might take you more than today, would you mind if I please pick this up?

@debjit-bw
Copy link
Contributor

Hey @mattsse, I just raised the PR for this #12134

@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants
@mattsse @debjit-bw @hoank101 and others