Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace thiserror-no-std with thiserror v2 #12349

Open
DaniPopes opened this issue Nov 6, 2024 · 3 comments · May be fixed by #12432
Open

Replace thiserror-no-std with thiserror v2 #12349

DaniPopes opened this issue Nov 6, 2024 · 3 comments · May be fixed by #12432
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@DaniPopes
Copy link
Member

Describe the feature

thiserror released version 2 which includes no_std support: https://github.com/dtolnay/thiserror/releases/tag/2.0.0

thiserror must also be added with default-features = false

Additional context

No response
@DaniPopes DaniPopes added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started labels Nov 6, 2024
@kien6034
Copy link
Contributor

kien6034 commented Nov 6, 2024

I want to take this

@kien6034 kien6034 mentioned this issue Nov 6, 2024
Closed
@ryzen-xp
Copy link

ryzen-xp commented Nov 8, 2024

I'd like to take this issue.
Please assign me

@kien6034
Copy link
Contributor

kien6034 commented Nov 9, 2024 •
edited
Loading

@ryzen-xp please work on this, i tried but got problem with the CI, probably i did something wrong.

@stevencartavia stevencartavia linked a pull request Nov 9, 2024 that will close this issue
Draft
@TropicalDog17 TropicalDog17 mentioned this issue Nov 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Status: Todo
Milestone
No milestone
3 participants
@kien6034 @DaniPopes @ryzen-xp