-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move more provider traits into storage-api crate #12478
Comments
cool, ty! |
Which other traits do you think are relevant to this task? |
this one we can move as well
|
I had a look again on this and it seems it is used here:
Do you still consider that it should be moved to storage-api crate? |
hmm, actually not sure about this one because this is kinda p2p, so we can keep this particular one for now |
Cool. What else do you think is necessary to resolve this ticket? |
Describe the feature
we still have a few traits defined in the reth-provider crate that are independent of reth-provider internals, like
reth/crates/storage/provider/src/traits/history.rs
Line 10 in e6a6fc4
all of those should be moved to
reth/crates/storage/storage-api/Cargo.toml
Line 2 in e6a6fc4
ideally, trait by trait to make review easy.
can be re-exported from reth-provider to not break a ton of stuff
Additional context
No response
The text was updated successfully, but these errors were encountered: