Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Box<BlindedProviderFactory> in Sparse Trie #13307

Open
shekhirin opened this issue Dec 11, 2024 · 3 comments · May be fixed by #13463
Open

Use Box<BlindedProviderFactory> in Sparse Trie #13307

shekhirin opened this issue Dec 11, 2024 · 3 comments · May be fixed by #13463
Assignees
@nadtech-hub
Labels
A-trie Related to Merkle Patricia Trie implementation C-debt Refactor of code section that is hard to understand or maintain

Comments

@shekhirin
Copy link
Collaborator

Describe the feature

Follow-up to #13294: avoid generics everywhere by boxing the BlindedProviderFactory and its associated types.

Additional context

No response
@shekhirin shekhirin added A-trie Related to Merkle Patricia Trie implementation C-debt Refactor of code section that is hard to understand or maintain labels Dec 11, 2024
@nadtech-hub
Copy link
Contributor

✋

@shekhirin shekhirin changed the title Use Box<BlindedProviderFactory in Sparse Trie Use Box<BlindedProviderFactory> in Sparse Trie Dec 13, 2024
@shekhirin
Copy link
Collaborator Author

@nadtech-hub assigned, let me know if you have any questions

@nadtech-hub
Copy link
Contributor

nadtech-hub commented Dec 18, 2024 •
edited
Loading

trie typed with provider is boxed as much as I can see. Should all occurrences of BlindedProviderFactory be boxed?
Image

You probably meant occurrences of Provider like in this case
Image

@nadtech-hub nadtech-hub linked a pull request Dec 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadtech-hub nadtech-hub

Labels
A-trie Related to Merkle Patricia Trie implementation C-debt Refactor of code section that is hard to understand or maintain
Projects
Reth Tracker
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: SparseStateTrie's BlindedProviderFactory is boxed nadtech-hub/reth
2 participants
@shekhirin @nadtech-hub