Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hive engine: detect missing final block #2673

Closed
1 task done
Tracked by #2625
mattsse opened this issue May 15, 2023 · 1 comment
Closed
1 task done
Tracked by #2625

Hive engine: detect missing final block #2673

mattsse opened this issue May 15, 2023 · 1 comment
Labels
A-consensus Related to the consensus engine A-rpc Related to the RPC implementation

Comments

@mattsse
Copy link
Collaborator

mattsse commented May 15, 2023

Describe the bug

A missing final block should result in

{"code":-38002,"message":"Invalid forkchoice state","data":{"err":"final block not available in database"}}}

./hive --client reth --sim ethereum/engine --sim.limit "/Unknown FinalizedBlockHash"

Steps to reproduce

./hive --client reth --sim ethereum/engine --sim.limit "/Unknown FinalizedBlockHash"

Node logs

No response

Platform(s)

No response

What version/commit are you on?

No response

Code of Conduct

  • I agree to follow the Code of Conduct
@mattsse mattsse added C-bug An unexpected or incorrect behavior S-needs-triage This issue needs to be labelled labels May 15, 2023
@mattsse mattsse mentioned this issue May 15, 2023
Closed
@mattsse mattsse added A-rpc Related to the RPC implementation A-consensus Related to the consensus engine and removed C-bug An unexpected or incorrect behavior S-needs-triage This issue needs to be labelled labels May 15, 2023
@mattsse mattsse mentioned this issue May 15, 2023
Merged
@mattsse
Copy link
Collaborator Author

mattsse commented May 19, 2023

this is now caught

@mattsse mattsse closed this as completed May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-consensus Related to the consensus engine A-rpc Related to the RPC implementation
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mattsse