Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy errors #3544

Closed
rkrasiuk opened this issue Jul 3, 2023 · 5 comments
Closed

Fix clippy errors #3544

rkrasiuk opened this issue Jul 3, 2023 · 5 comments
Labels
C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started S-stale This issue/PR is stale and will close with no further activity

Comments

@rkrasiuk
Copy link
Member

rkrasiuk commented Jul 3, 2023

#3540 silenced some annoying clippy errors.

They need to fixed either by upgrading deps or opening issues in corresponding repos:
Screenshot 2023-07-03 at 14 09 29

To repro run cargo clippy --all --all-features on latest nightly

@rkrasiuk rkrasiuk added the C-debt Refactor of code section that is hard to understand or maintain label Jul 3, 2023
@shekhirin shekhirin added the D-good-first-issue Nice and easy! A great choice to get started label Jul 3, 2023
@tcoratger
Copy link
Contributor

@rkrasiuk What is the last nightly you considered? Following this, I've 1.72.0 and I've no error running cargo clippy --all --all-features

@rkrasiuk
Copy link
Member Author

rkrasiuk commented Jul 3, 2023

i've run it on rustc 1.72.0-nightly (839e9a6e1 2023-07-02) <- date matters

@cjeva10
Copy link
Contributor

cjeva10 commented Jul 6, 2023

The incorrect implementation of clone on Copy type errors are from parity's fixed-hash crate. construct_fixed_hash implements clone by creating a new fixed hash with zero bits rather than dereferencing self (replace clone function body with *self).

Not sure if changing this behavior would screw things up elsewhere though.

@github-actions
Copy link
Contributor

This issue is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Jul 21, 2023
@github-actions
Copy link
Contributor

This issue was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 29, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started S-stale This issue/PR is stale and will close with no further activity
Projects
Archived in project
Development

No branches or pull requests

4 participants