Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dedicated subpool for tracking all blob transactions #4445

Closed
mattsse opened this issue Aug 31, 2023 · 2 comments
Closed

Add dedicated subpool for tracking all blob transactions #4445

mattsse opened this issue Aug 31, 2023 · 2 comments
Assignees
Labels
A-tx-pool Related to the transaction mempool C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Aug 31, 2023

Describe the feature

blob transactions should never have a nonce gap: #4405
and also only be allowed if the sender overdrafts at the time of insert, so they should never initially enter the parked subpool.

A blob tx is pending if it satisfies the base fee and the pending blob fee.
the max_fee_per_blob however does not affect the final tx fee since the blob fee comes from the header (Header::blob_fee).

the max_fee_per_blob is however relevant when evicting transactions, because txs with max_fee_per_blob < pending_blob_fee are not considered pending.

To make it easier to keep track of blob transactions, they should be grouped in a separate subpool, so they can be updated more easily without scanning all transactions

Additional context

No response

@chirag-bgh
Copy link
Contributor

Hey @mattsse , just checking in here if you're going to take this or this is open for contributions. I would like to work on this if so.

@mattsse
Copy link
Collaborator Author

mattsse commented Sep 11, 2023

hey, @chirag-bgh

ty, however, I'm already wrapping up this feature, there will be a few followups, so I'll tag you there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tx-pool Related to the transaction mempool C-enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants