Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reth-rpc won't build due to renamed enum in reth-primitives #4705

Closed
1 task done
petertdavies opened this issue Sep 21, 2023 · 0 comments · Fixed by #4706
Closed
1 task done

reth-rpc won't build due to renamed enum in reth-primitives #4705

petertdavies opened this issue Sep 21, 2023 · 0 comments · Fixed by #4706
Labels
C-bug An unexpected or incorrect behavior

Comments

@petertdavies
Copy link
Contributor

Describe the bug

revm_primitives::InvalidTransaction::GasMaxFeeGreaterThanPriorityFee was renamed to PriorityFeeGreaterThanMaxFee upstream. This breaks reth-rpc which pattern matches this variant. The build breakage is currently masked by Cargo.lock, but that doesn't help people trying to build on top of Reth.

Steps to reproduce

  1. Checkout Reth
  2. rm Cargo.lock
  3. cargo build
   Compiling reth-rpc v0.1.0-alpha.8 (/home/ptd/Projects/reth/crates/rpc/rpc)
error[E0599]: no variant or associated item named `GasMaxFeeGreaterThanPriorityFee` found for enum `revm_primitives::InvalidTransaction` in the current scope
   --> crates/rpc/rpc/src/eth/error.rs:373:33
    |
373 |             InvalidTransaction::GasMaxFeeGreaterThanPriorityFee => {
    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ variant or associated item not found in `InvalidTransaction`

For more information about this error, try `rustc --explain E0599`.
error: could not compile `reth-rpc` (lib) due to previous error

Node logs

No response

Platform(s)

Linux (x86)

What version/commit are you on?

f00df57

What database version are you on?

No response

If you've built Reth from source, provide the full command you used

No response

Code of Conduct

  • I agree to follow the Code of Conduct
@petertdavies petertdavies added C-bug An unexpected or incorrect behavior S-needs-triage This issue needs to be labelled labels Sep 21, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Sep 21, 2023
@DaniPopes DaniPopes removed the S-needs-triage This issue needs to be labelled label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug An unexpected or incorrect behavior
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants