Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hive Pre-Merge Fork Number > 0 test fails #4809

Closed
1 task done
Tracked by #2625
Rjected opened this issue Sep 27, 2023 · 2 comments
Closed
1 task done
Tracked by #2625

hive Pre-Merge Fork Number > 0 test fails #4809

Rjected opened this issue Sep 27, 2023 · 2 comments
Labels
C-bug An unexpected or incorrect behavior C-test A change that impacts how or what we test E-cancun Related to the Cancun network upgrade M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity S-needs-investigation This issue requires detective work to figure out what's going wrong

Comments

@Rjected
Copy link
Member

Rjected commented Sep 27, 2023

Describe the bug

We currently fail the cancun hive test Pre-Merge Fork Number > 0 with the following log:

CLMocker: Client: c001ca38, Block 0: {
 "parentHash": "0x0000000000000000000000000000000000000000000000000000000000000000",
 "sha3Uncles": "0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347",
 "miner": "0x0000000000000000000000000000000000000000",
 "stateRoot": "0x273a39ea90b7aae7ce403ac5ebf93c97d405e9a673cb30867f721b661876b5b1",
 "transactionsRoot": "0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421",
 "receiptsRoot": "0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421",
 "logsBloom": "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
 "difficulty": "0x0",
 "number": "0x0",
 "gasLimit": "0x2fefd8",
 "gasUsed": "0x0",
 "timestamp": "0x1234",
 "extraData": "0x",
 "mixHash": "0x0000000000000000000000000000000000000000000000000000000000000000",
 "nonce": "0x0000000000000000",
 "baseFeePerGas": null,
 "withdrawalsRoot": "0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421",
 "blobGasUsed": null,
 "excessBlobGas": null,
 "parentBeaconBlockRoot": null,
 "hash": "0x39da863060a2d85c200ffb7036a14004ca8ff85f7709ba0a55fd3b76a2ea59d3"
}
CLMocker: Selected payload producer: c001ca38
>> (c001ca38) {"jsonrpc":"2.0","id":4,"method":"eth_getBlockByNumber","params":["latest",false]}
<< (c001ca38) {"jsonrpc":"2.0","result":{"hash":"0x5fd1bc5f3c46ae397a095d562eaf52e1100747bf615eecf8b8de27cc95321f81","parentHash":"0x0000000000000000000000000000000000000000000000000000000000000000","sha3Uncles":"0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347","miner":"0x0000000000000000000000000000000000000000","stateRoot":"0x273a39ea90b7aae7ce403ac5ebf93c97d405e9a673cb30867f721b661876b5b1","transactionsRoot":"0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421","receiptsRoot":"0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421","logsBloom":"0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000","difficulty":"0x0","number":"0x0","gasLimit":"0x2fefd8","gasUsed":"0x0","timestamp":"0x1234","extraData":"0x","mixHash":"0x0000000000000000000000000000000000000000000000000000000000000000","nonce":"0x0000000000000000","withdrawalsRoot":"0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421","totalDifficulty":"0x0","uncles":[],"transactions":[],"size":"0x21d","withdrawals":[]},"id":4}
>> (c001ca38) {"jsonrpc":"2.0","id":1,"method":"engine_forkchoiceUpdatedV3","params":[{"headBlockHash":"0x39da863060a2d85c200ffb7036a14004ca8ff85f7709ba0a55fd3b76a2ea59d3","safeBlockHash":"0x0000000000000000000000000000000000000000000000000000000000000000","finalizedBlockHash":"0x0000000000000000000000000000000000000000000000000000000000000000"},{"timestamp":"0x1235","prevRandao":"0xb9acbc21b7e05a371a2749e943b2435e6e6225089f7dec4e23bc4104165f82e1","suggestedFeeRecipient":"0x0000000000000000000000000000000000000000","withdrawals":[{"index":"0x1","validatorIndex":"0x0","address":"0x0000000000000000000000000000000000000000","amount":"0x64"},{"index":"0x2","validatorIndex":"0x1","address":"0x0100000000000000000000000000000000000000","amount":"0x64"},{"index":"0x3","validatorIndex":"0x2","address":"0x0200000000000000000000000000000000000000","amount":"0x64"},{"index":"0x4","validatorIndex":"0x3","address":"0x0300000000000000000000000000000000000000","amount":"0x64"},{"index":"0x5","validatorIndex":"0x4","address":"0x0400000000000000000000000000000000000000","amount":"0x64"},{"index":"0x6","validatorIndex":"0x5","address":"0x0500000000000000000000000000000000000000","amount":"0x64"},{"index":"0x7","validatorIndex":"0x6","address":"0x0600000000000000000000000000000000000000","amount":"0x64"},{"index":"0x8","validatorIndex":"0x7","address":"0x0700000000000000000000000000000000000000","amount":"0x64"},{"index":"0x9","validatorIndex":"0x8","address":"0x0800000000000000000000000000000000000000","amount":"0x64"},{"index":"0xa","validatorIndex":"0x9","address":"0x0900000000000000000000000000000000000000","amount":"0x64"}],"parentBeaconBlockRoot":"0x169630f535b4a41330164c6e5c92b1224c0c407f582d407d0ac3d206cd32fd52"}]}
<< (c001ca38) {"jsonrpc":"2.0","result":{"payloadStatus":{"status":"SYNCING","latestValidHash":null,"validationError":null},"payloadId":null},"id":1}
CLMocker: Unexpected forkchoiceUpdated Response from Payload builder: {{SYNCING <nil> <nil>} <nil>}
CLMocker: Closing engine client c001ca38

The CL in the hive test is sending a FCU for 0x39da863060a2d85c200ffb7036a14004ca8ff85f7709ba0a55fd3b76a2ea59d3, which should be the genesis block hash, but for some reason, we are returning a block 0 with a hash of 0x5fd1bc5f3c46ae397a095d562eaf52e1100747bf615eecf8b8de27cc95321f81.

Steps to reproduce

Run hive:

./hive --sim ethereum/engine --client reth --sim.limit "cancun/Pre-Merge"

Node logs

No response

Platform(s)

No response

What version/commit are you on?

No response

What database version are you on?

No response

If you've built Reth from source, provide the full command you used

No response

Code of Conduct

  • I agree to follow the Code of Conduct
@Rjected Rjected added C-bug An unexpected or incorrect behavior S-needs-investigation This issue requires detective work to figure out what's going wrong C-test A change that impacts how or what we test E-cancun Related to the Cancun network upgrade labels Sep 27, 2023
@Rjected Rjected added the M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity label Sep 27, 2023
@Rjected
Copy link
Member Author

Rjected commented Dec 15, 2023

This still fails

@Rjected
Copy link
Member Author

Rjected commented Mar 15, 2024

This is fixed now

@Rjected Rjected closed this as completed Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug An unexpected or incorrect behavior C-test A change that impacts how or what we test E-cancun Related to the Cancun network upgrade M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity S-needs-investigation This issue requires detective work to figure out what's going wrong
Projects
Archived in project
Development

No branches or pull requests

1 participant