Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AccessList and input fields to MockTransaction #4901

Closed
mattsse opened this issue Oct 4, 2023 · 2 comments · Fixed by #4904
Closed

Add AccessList and input fields to MockTransaction #4901

mattsse opened this issue Oct 4, 2023 · 2 comments · Fixed by #4904
Assignees
Labels
C-enhancement New feature or request C-test A change that impacts how or what we test D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Oct 4, 2023

Describe the feature

The MockTransaction variants currently don't have input/tx list fields

#[derive(Debug, Clone, Eq, PartialEq)]
pub enum MockTransaction {
Legacy {
hash: B256,
sender: Address,
nonce: u64,
gas_price: u128,
gas_limit: u64,
to: TransactionKind,
value: U256,
},
Eip1559 {
hash: B256,
sender: Address,
nonce: u64,
max_fee_per_gas: u128,
max_priority_fee_per_gas: u128,
gas_limit: u64,
to: TransactionKind,
value: U256,
},
Eip4844 {
hash: B256,
sender: Address,
nonce: u64,
max_fee_per_gas: u128,
max_priority_fee_per_gas: u128,
max_fee_per_blob_gas: u128,
gas_limit: u64,
to: TransactionKind,
value: U256,
},
}

TODO

  • add accesslist field
  • add input fields

this should mirror the actual transaction enum variants

pub enum Transaction {

do you want to take this @DoTheBestToGetTheBest ?

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Oct 4, 2023
@DoTheBestToGetTheBest
Copy link
Contributor

i take this

@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started C-test A change that impacts how or what we test and removed S-needs-triage This issue needs to be labelled labels Oct 4, 2023
@mattsse
Copy link
Collaborator Author

mattsse commented Oct 4, 2023

this pr is about to be merged in the next minutes which adds relevant getter functions for accesslist and input that need to be updated as well

#4867

@mattsse mattsse linked a pull request Oct 5, 2023 that will close this issue
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request C-test A change that impacts how or what we test D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants