Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate TransactionSigned::recover_signers performance #5189

Closed
joshieDo opened this issue Oct 26, 2023 · 3 comments
Closed

Investigate TransactionSigned::recover_signers performance #5189

joshieDo opened this issue Oct 26, 2023 · 3 comments
Labels
A-staged-sync Related to staged sync (pipelines and stages) S-needs-benchmark This set of changes needs performance benchmarking to double-check that they help S-needs-investigation This issue requires detective work to figure out what's going wrong S-stale This issue/PR is stale and will close with no further activity

Comments

@joshieDo
Copy link
Collaborator

Describe the feature

Currently TransactionSigned::recover_signers uses into_par_iter, and although rayon does handle it in a nice way, there might be some more performance to gain from using a chunk approach similar to the one in SenderRecoveryStage.

Probably unifying is the best outcome here. Chunk + Threshold.

Requires benchmarking.

Additional context

No response
@joshieDo joshieDo added S-needs-investigation This issue requires detective work to figure out what's going wrong A-staged-sync Related to staged sync (pipelines and stages) S-needs-benchmark This set of changes needs performance benchmarking to double-check that they help labels Oct 26, 2023
@Arindam2407
Copy link
Contributor

can I take this? Might take me some time to understand since its my first issue

This was referenced Oct 30, 2023
Closed
Closed
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Nov 26, 2023
@Arindam2407 Arindam2407 mentioned this issue Nov 29, 2023
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

This issue was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 4, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-staged-sync Related to staged sync (pipelines and stages) S-needs-benchmark This set of changes needs performance benchmarking to double-check that they help S-needs-investigation This issue requires detective work to figure out what's going wrong S-stale This issue/PR is stale and will close with no further activity
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshieDo @Arindam2407