Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: is_some utils for Header #5802

Closed
tcoratger opened this issue Dec 17, 2023 · 0 comments · Fixed by #5969
Closed

refactor: is_some utils for Header #5802

tcoratger opened this issue Dec 17, 2023 · 0 comments · Fixed by #5969
Labels
C-enhancement New feature or request

Comments

@tcoratger
Copy link
Contributor

Describe the change

At the moment, there are different places of the codebase where we use the is_some method for some fields of the header structure like:

self.parent_beacon_block_root.is_some()

or

} else if header.excess_blob_gas.is_some() {

For ease of use and a slightly less verbose implementation, wouldn't it be useful to implement directly within the Header structure methods such as is_some_excess_blob_gas, is_some_parent_beacon_block_root, etc?

Additional context

No response

@tcoratger tcoratger added C-docs An addition or correction to our documentation S-needs-triage This issue needs to be labelled labels Dec 17, 2023
@DaniPopes DaniPopes added C-enhancement New feature or request and removed C-docs An addition or correction to our documentation S-needs-triage This issue needs to be labelled labels Dec 28, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants