Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rpc config and builder types #604

Closed
Tracked by #37
mattsse opened this issue Dec 25, 2022 · 2 comments
Closed
Tracked by #37

Add Rpc config and builder types #604

mattsse opened this issue Dec 25, 2022 · 2 comments
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Dec 25, 2022

Describe the feature

rpc modules in the rpc crate can be merged to a RpcModule via: https://docs.rs/jsonrpsee/0.16.2/jsonrpsee/struct.RpcModule.html#method.merge

to makes this convenient to use we need

  • config type: what transports (HTTP, ws, ipc) to enable and what namespaces
  • builder type: that allows to easily merge reth rpc modules

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled A-rpc Related to the RPC implementation and removed S-needs-triage This issue needs to be labelled labels Dec 25, 2022
@onbjerg
Copy link
Member

onbjerg commented Dec 25, 2022

One thing to keep in mind is that we need 2 entirely different RPC endpoints, since a requirement of the engine spec is that the engine namespace is exposed on a different endpoint (along with some of the eth namespace)

This was referenced Jan 13, 2023
@mattsse mattsse added the D-good-first-issue Nice and easy! A great choice to get started label Jan 24, 2023
@mattsse
Copy link
Collaborator Author

mattsse commented Jan 25, 2023

all types/api has been added.

will followup with targeted issues for remaining tasks

@mattsse mattsse closed this as completed Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

No branches or pull requests

2 participants