Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reth bootnode command #7277

Open
Rjected opened this issue Mar 21, 2024 · 11 comments
Open

reth bootnode command #7277

Rjected opened this issue Mar 21, 2024 · 11 comments
Labels
A-cli Related to the reth CLI A-discv4 Related to discv4 discovery A-discv5 Related to discv5 discovery C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity

Comments

@Rjected
Copy link
Member

Rjected commented Mar 21, 2024

Describe the feature

Geth currently has a bootnode binary that can be run, to be a standalone bootnode for discv4 (or discv5):

https://github.com/ethereum/go-ethereum/blob/14eb8967be7acc54c5dc9a416151ac45c01251b6/cmd/bootnode/main.go#L39-L48

We should introduce a new command that runs the discovery stack in a similar way, with the same flags (except the log level ones)

Additional context

No response

@Rjected Rjected added C-enhancement New feature or request A-cli Related to the reth CLI A-discv4 Related to discv4 discovery A-discv5 Related to discv5 discovery labels Mar 21, 2024
@mattsse mattsse added the D-good-first-issue Nice and easy! A great choice to get started label Mar 21, 2024
@AbnerZheng
Copy link
Contributor

I can give it a try in this weekend.

Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Apr 13, 2024
@onbjerg onbjerg added M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity and removed S-stale This issue/PR is stale and will close with no further activity labels Apr 13, 2024
@ch4r10t33r
Copy link

Hey can I take this one?

@AbnerZheng
Copy link
Contributor

yeah, I don't have enough bandwidth for it. Take it if you want

@ch4r10t33r
Copy link

If I understand this correct, the requirement is to create a new command which can be run as reth bootnode <params> (and not as a separate standalone tool?). @Rjected

@Rjected
Copy link
Member Author

Rjected commented Apr 24, 2024

If I understand this correct, the requirement is to create a new command which can be run as reth bootnode <params> (and not as a separate standalone tool?). @Rjected

Yep exactly!

@Rjected
Copy link
Member Author

Rjected commented Jun 6, 2024

@ch4r10t33r any updates here? do you need help or clarification on something?

@harsh-ps-2003
Copy link
Contributor

@Rjected as far as I can understand we want to implement a bootnode command similar to Geth's, but integrated into the Reth CLI rather than as a separate tool like this - reth p2p bootnode [options] (options like genkey, nodekey, nodekeyhex, addr, port, discv4/5). This bootnode subcommand would run the discovery service in a standalone mode without starting the full node most probably? I am guessing it would output encode URL for other nodes to use. Basically useful in private networks, testiest stuff.
I guess I am right, but this looks daunting to me, should I give it a try sometime?

@raa-dev
Copy link

raa-dev commented Jan 8, 2025

Hey (:
Is this still an open issue? is there any WIP? I'd like to help @ch4r10t33r
cc. @Rjected @harsh-ps-2003

@manav2401
Copy link

Hey @Rjected, geth seems to have removed the bootnode command in this PR given they don't support custom networks anymore. Is this task still needed? If yes, I can give it a try. Thanks!

@temaniarpit27
Copy link
Contributor

Hey
I would like this to try if this issue is still valid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI A-discv4 Related to discv4 discovery A-discv5 Related to discv5 discovery C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity
Projects
Status: Todo
Development

No branches or pull requests

9 participants