Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ots_getInternalOperations #7310

Closed
mattsse opened this issue Mar 23, 2024 · 1 comment · Fixed by #7332
Closed

Implement ots_getInternalOperations #7310

mattsse opened this issue Mar 23, 2024 · 1 comment · Fixed by #7332
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Mar 23, 2024

Describe the feature

Needs inspector in evm-inspectors

paradigmxyz/revm-inspectors#76

TODO:

implement

/// Handler for `ots_getInternalOperations`
async fn get_internal_operations(&self, _tx_hash: TxHash) -> RpcResult<Vec<InternalOperation>> {
Err(internal_rpc_err("unimplemented"))
}

extend trait bounds to EthTransactions, ref #7309

see also for reference:

/// Replays a transaction, returning the traces.
pub async fn replay_transaction(
&self,
hash: B256,
trace_types: HashSet<TraceType>,
) -> EthResult<TraceResults> {
let config = TracingInspectorConfig::from_parity_config(&trace_types);
self.inner
.eth_api
.spawn_trace_transaction_in_block(hash, config, move |_, inspector, res, db| {
let trace_res = inspector.into_parity_builder().into_trace_results_with_state(
&res,
&trace_types,
&db,
)?;
Ok(trace_res)
})
.await
.transpose()
.ok_or_else(|| EthApiError::TransactionNotFound)?
}

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Mar 23, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started A-rpc Related to the RPC implementation and removed S-needs-triage This issue needs to be labelled labels Mar 23, 2024
@AbnerZheng
Copy link
Contributor

Will give it a try once the inspector be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants