Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Otterscan types to alloy #7372

Closed
mattsse opened this issue Mar 28, 2024 · 3 comments
Closed

Move Otterscan types to alloy #7372

mattsse opened this issue Mar 28, 2024 · 3 comments
Assignees
@nkysg
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Mar 28, 2024

Describe the feature

These types can be reused by reth+anvil or any other server

reth/crates/rpc/rpc-types/src/otterscan.rs

Line 2 in 33c466d

and we should move them to

https://github.com/alloy-rs/alloy/blob/66fa1924a4f9165a0842838c5150260d0dd6de30/crates/rpc-trace-types/Cargo.toml#L2

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started A-rpc Related to the RPC implementation labels Mar 28, 2024
@nkysg
Copy link
Contributor

nkysg commented Mar 28, 2024

I can try it

@nkysg nkysg mentioned this issue Mar 28, 2024
Merged
@nkysg
Copy link
Contributor

nkysg commented Mar 28, 2024

If this alloy-rs/alloy#418 pr accepted, I will commit a pr for reth.

@mattsse
Copy link
Collaborator Author

mattsse commented Mar 28, 2024

it's possible that this is currently blocked by paradigmxyz/revm-inspectors#78

@mattsse mattsse closed this as completed Apr 8, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkysg nkysg

Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nkysg @mattsse