Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace TransactionKind with alloy_primitives::TxKind #7690

Closed
mattsse opened this issue Apr 16, 2024 · 3 comments · Fixed by #7859
Closed

Replace TransactionKind with alloy_primitives::TxKind #7690

mattsse opened this issue Apr 16, 2024 · 3 comments · Fixed by #7859
Labels
C-debt Refactor of code section that is hard to understand or maintain C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Apr 16, 2024 •
edited
Loading

Describe the feature

ref #7050

blocked by alloy-rs/core#604 and new release

TODO

  • remove reth-primitives::TransactionKind and use alloy_primitives::TxKind
  • update usage

the easiest approach for this is:

  1. rename reth-primitives::TransactionKind to TxKind
  2. remove that type
  3. reexport alloy_primitives::TxKind

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Apr 16, 2024
@mattsse mattsse added S-blocked This cannot more forward until something else changes C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started and removed S-needs-triage This issue needs to be labelled labels Apr 16, 2024
@rodrigoherrerai
Copy link
Contributor

I can take it

@mattsse
Copy link
Collaborator Author

mattsse commented Apr 16, 2024

currently blocked by new alloy release
will ping when unblocked

@mattsse mattsse removed the S-blocked This cannot more forward until something else changes label Apr 24, 2024
@mattsse
Copy link
Collaborator Author

mattsse commented Apr 24, 2024

@rodrigoherrerai unblocked with new alloy release

@rodrigoherrerai rodrigoherrerai mentioned this issue Apr 25, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace TransactionKind with alloy_primitives::TxKind rodrigoherrerai/reth
2 participants
@mattsse @rodrigoherrerai