Make txpool independent of primitive tx types

[mattsse]

Describe the feature

we need a tx trait abstraction for these conversions:

reth/crates/transaction-pool/src/traits.rs

Lines 756 to 764 in c733859

	/// Trait for transaction types used inside the pool
	pub trait PoolTransaction:
	fmt::Debug
	+ Send
	+ Sync
	+ FromRecoveredPooledTransaction
	+ TryFromRecoveredTransaction
	+ IntoRecoveredTransaction
	{

reth/crates/primitives/src/transaction/mod.rs

Lines 1606 to 1618 in c733859

	pub trait FromRecoveredPooledTransaction {
	/// Converts to this type from the given [`PooledTransactionsElementEcRecovered`].
	fn from_recovered_pooled_transaction(tx: PooledTransactionsElementEcRecovered) -> Self;
	}
	/// The inverse of [`TryFromRecoveredTransaction`] that ensure the transaction can be sent over the
	/// network
	pub trait IntoRecoveredTransaction {
	/// Converts to this type into a [`TransactionSignedEcRecovered`].
	///
	/// Note: this takes `&self` since indented usage is via `Arc<Self>`.
	fn to_recovered_transaction(&self) -> TransactionSignedEcRecovered;
	}

this likely requires additional associated types on the pool trait, where we use it, for example when returning the pooled variant.
like type PooledTx; which then have the conversions

reth/crates/transaction-pool/src/traits.rs

Lines 44 to 45 in c733859

	/// The transaction type of the pool
	type Transaction: PoolTransaction;

Update

after ##9916 we can continue with trying to gradually remove the bounds:

reth/crates/transaction-pool/src/traits.rs

Lines 761 to 763 in c71c813

	+ From<PooledTransactionsElementEcRecovered>
	+ TryFrom<TransactionSignedEcRecovered>
	+ Into<TransactionSignedEcRecovered>

we can approach this by identifying where these are used, and trying to enforce these bounds there, for example T: Trasactionpool < Consensus = TransactionSignedEcRecovered> etc...

and also remove these types from the Transactionpool trait and use the AT instead, this likely requires some additional bounds or traits on the impl:

reth/crates/transaction-pool/src/traits.rs

Lines 223 to 237 in c71c813

	fn get_pooled_transaction_elements(
	&self,
	tx_hashes: Vec<TxHash>,
	limit: GetPooledTransactionLimit,
	) -> Vec<PooledTransactionsElement>;
	/// Returns converted [PooledTransactionsElement] for the given transaction hash.
	///
	/// This adheres to the expected behavior of
	/// [`GetPooledTransactions`](https://github.com/ethereum/devp2p/blob/master/caps/eth.md#getpooledtransactions-0x09):
	///
	/// If the transaction is a blob transaction, the sidecar will be included.
	///
	/// Consumer: P2P
	fn get_pooled_transaction_element(&self, tx_hash: TxHash) -> Option<PooledTransactionsElement>;

FYI @tcoratger in case you want to continue

Additional context

No response

[JackG-eth]

Will take this

[JackG-eth]

@mattsse Sorry for the delay, will be picking this up again now.