Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--debug.etherscan should not crash the node #9000

Closed
shekhirin opened this issue Jun 20, 2024 · 0 comments · Fixed by #9003
Closed

--debug.etherscan should not crash the node #9000

shekhirin opened this issue Jun 20, 2024 · 0 comments · Fixed by #9003
Assignees
Labels
C-bug An unexpected or incorrect behavior D-good-first-issue Nice and easy! A great choice to get started

Comments

@shekhirin
Copy link
Collaborator

shekhirin commented Jun 20, 2024

Problem

thread 'tokio-runtime-worker' panicked at /Users/shekhirin/.cargo/git/checkouts/reth-36d3ea1d1152b20c/8deaea4/crates/consensus/debug-client/src/client.rs:103:14:
called `Result::unwrap()` on an `Err` value: RequestTimeout
2024-06-20T19:11:14.498140Z ERROR Critical task `etherscan consensus client` panicked: `called `Result::unwrap()` on an `Err` value: RequestTimeout`
2024-06-20T19:11:14.498396Z ERROR shutting down due to error
Error: Critical task `etherscan consensus client` panicked: `called `Result::unwrap()` on an `Err` value: RequestTimeout

Solution

We shouldn't do a panicking .unwrap() here

// Send new events to execution client
reth_rpc_api::EngineApiClient::<T>::new_payload_v3(
&execution_client,
payload.execution_payload_v3,
payload.versioned_hashes,
payload.parent_beacon_block_root,
)
.await
.unwrap();

instead, log an error and proceed with the loop

@shekhirin shekhirin added C-bug An unexpected or incorrect behavior D-good-first-issue Nice and easy! A great choice to get started labels Jun 20, 2024
@mattsse mattsse self-assigned this Jun 20, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug An unexpected or incorrect behavior D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants