Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace raw usage of revm evm builder with EvmConfig usage #9189

Closed
mattsse opened this issue Jun 29, 2024 · 1 comment · Fixed by #9190
Closed

replace raw usage of revm evm builder with EvmConfig usage #9189

mattsse opened this issue Jun 29, 2024 · 1 comment · Fixed by #9190
Assignees
@sboou
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jun 29, 2024

Describe the feature

this should be replaced

reth/crates/rpc/rpc/src/eth/bundle.rs

Lines 124 to 125 in f4689f3

revm::Evm::builder().with_db(db).with_env_with_handler_cfg(env).build();

with EvmConfig::evm_with_env

reth/crates/rpc/rpc-eth-api/src/helpers/call.rs

Line 299 in f4689f3

let mut evm = self.evm_config().evm_with_env(db, env);

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started labels Jun 29, 2024
@sboou
Copy link
Contributor

sboou commented Jun 29, 2024

please assign

@sboou sboou mentioned this issue Jun 29, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sboou sboou

Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: replace raw usage of revm evm builder with EvmConfig usage sboou/reth
2 participants
@mattsse @sboou